johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
376 stars 124 forks source link

Added notebook for zero-shot object detection #78

Closed Vishnunkumar closed 7 months ago

Vishnunkumar commented 7 months ago

CLIP-CROP

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

merveenoyan commented 7 months ago

@Vishnunkumar it is very end to end, I just had some suggestions about the wording and the docstrings. Maybe you could also add a bit of text descriptions under the headers :) After you iterate, if it looks good we can merge!

Vishnunkumar commented 7 months ago

Hi @merveenoyan , thanks for the suggestions. I will review them and update. I am really grateful and elated to contribute to HuggingFace.

johko commented 7 months ago

Hey @Vishnunkumar - really cool example you put together here. I would mention the same as @merveenoyan , maybe still a bit more text describing what happens in the steps would be nice (you are already doing it well at the beginning). But apart from that looks great :+1:

Vishnunkumar commented 7 months ago

Hi team,

Thanks for the valuable feedback, have upgraded the descriptions to contain more information.

Vishnunkumar commented 7 months ago

Hi team,

Thanks for the valuable feedback, have updated the descriptions to provide apt context about the notebook.

Vishnunkumar commented 7 months ago

Thanks for accepting my PR, I am grateful for being a part of the HuggingFace community. 😄