search

johm / borges

AKA Infoshopkeeper2
GNU General Public License v3.0
6 stars 2 forks source link

Theme enhancements #50

Closed robinhoode closed 10 years ago

robinhoode commented 10 years ago

Two main features here:

1) Put the frontpage under the themes section 2) Add a method to ApplicationHelper called theme_partial, so the theme variable isn't hanging around, and is neatly tucked into the method

(1) is only there to help make room for my wsbooks folder that I have yet to create.

(2) helps to make it clear that certain elements are from the themes folder, and helps encourage further theme development.

robinhoode commented 10 years ago

@johm

Please look this over if you have time today. Thanks!

johm commented 10 years ago

this seems great. i will try to merge tomorrow---have been mucking around with templates today and want to make sure I do this right!

robinhoode commented 10 years ago

@johm

If you have a better solution, we can work towards that. I'm just trying to get this working so we can use it at the Wooden Shoe.

johm commented 10 years ago

No, this is a great solution :)

On 10/20/2013 05:16 PM, Robin Hoode wrote:

@johm https://github.com/johm

If you have a better solution, we can work towards that. I'm just trying to get this working so we can use it at the Wooden Shoe.

— Reply to this email directly or view it on GitHub https://github.com/johm/borges/pull/50#issuecomment-26682881.

robinhoode commented 10 years ago

Well, I can probably break this up into 2 commits, one for the method, and one for moving the files around, if that helps to speed up the merge process :smile:

robinhoode commented 10 years ago

I wrote a new PR for just the theme_partial method.