search

john-doherty / selenium-cucumber-js

Browser automation framework written in pure JavaScript using official selenium-webdriver and cucumber-js
ISC License
120 stars 89 forks source link

extra failure with new "eyes" integration #42

Closed bricas closed 7 years ago

bricas commented 7 years ago

I've installed the latest version (1.5.1) with the "eyes" integration -- which i don't actually use.

When i get a failure in my tests, i now also get the following:

Error: Promise factory was not initialized with proper callback
at PromiseFactory.makePromise (/var/lib/jenkins/workspace/unb-lib-tests/node_modules/eyes.utils/src/PromiseFactory.js:49:15)
at EyesBase.abortIfNotClosed (/var/lib/jenkins/workspace/unb-lib-tests/node_modules/eyes.sdk/src/EyesBase.js:968:32)
at /var/lib/jenkins/workspace/unb-lib-tests/node_modules/selenium-cucumber-js/runtime/world.js:229:33
at ManagedPromise.invokeCallback_ (/var/lib/jenkins/workspace/unb-lib-tests/node_modules/selenium-webdriver/lib/promise.js:1341:14)
at TaskQueue.execute_ (/var/lib/jenkins/workspace/unb-lib-tests/node_modules/selenium-webdriver/lib/promise.js:2950:14)
at TaskQueue.executeNext_ (/var/lib/jenkins/workspace/unb-lib-tests/node_modules/selenium-webdriver/lib/promise.js:2933:27)
at asyncRun (/var/lib/jenkins/workspace/unb-lib-tests/node_modules/selenium-webdriver/lib/promise.js:2793:27)
at /var/lib/jenkins/workspace/unb-lib-tests/node_modules/selenium-webdriver/lib/promise.js:675:7
at process._tickCallback (internal/process/next_tick.js:109:7)
Temi89 commented 7 years ago

@bricas I would have a look at it .

john-doherty commented 7 years ago

@bricas what version of node are you using?

bricas commented 7 years ago

I originally tested it against 7.x, now running 8.x (8.6, specifically) -- same error.

john-doherty commented 7 years ago

Have you tried removing an reinstalling node modules? rm -rf node_modules && npm install

bricas commented 7 years ago

it fails on a fresh install.

john-doherty commented 7 years ago

@Temi89 did you make any progress with this?

john-doherty commented 7 years ago

I've added some error checking around the eyes integration, can you try the latest version 1.5.2. If this fails, we need to back out the eyes integration work until @Temi89 has time to look at it

bricas commented 7 years ago

That seems to get rid of the eyes-related error i was seeing! Thanks.

john-doherty commented 7 years ago

Great. Thanks for raising it @bricas

bricas commented 7 years ago

👍

Temi89 commented 7 years ago

@john-doherty fixed the issue and checked in to my branch . Should have raised a pull request .