search

john-doherty / selenium-cucumber-js

Browser automation framework written in pure JavaScript using official selenium-webdriver and cucumber-js
ISC License
120 stars 89 forks source link

Inistead of requiring a specific node version, require a minimum version #65

Closed jogonzal closed 6 years ago

jogonzal commented 6 years ago

When using this package with yarn, I find myself having to specify "--ignore-engines". This is because this package requires a specific version of node as an engine, when it should be requiring a minimum version of node.

https://yarnpkg.com/en/docs/cli/install

This fixes #66

john-doherty commented 6 years ago

Thanks @jogonzal, if you can get the CI to pass I'll merge it

jogonzal commented 6 years ago

@john-doherty - it is passing now :). Could you publish a new version with this fix?

jogonzal commented 6 years ago

@john-doherty - friendly ping :)

jogonzal commented 6 years ago

@john-doherty - one more friendly ping :)

jogonzal commented 6 years ago

@john-doherty ping :)

mttwc commented 6 years ago

Jumping on the ping train, since we need this too :)

john-doherty commented 6 years ago

Done. Apologies for the delay!