Is it necessary for electron-prebuilt to be a hard dependency?

john-doherty / selenium-cucumber-js

Browser automation framework written in pure JavaScript using official selenium-webdriver and cucumber-js

ISC License

120 stars 89 forks source link

Is it necessary for electron-prebuilt to be a hard dependency? #86

Open octatone opened 5 years ago

octatone commented 5 years ago

I am running into issues in our CI with this specific dependency failing to download every so often, and it's not something we ever use. We use chromedriver exclusively. Can electron & electron-prebuilt be moved to optional dependencies?

berickson1 commented 5 years ago

+1 running into issues with this as well. The download task inside electron-prebuild to grab from github releases is unreliable on my build machines