search

john-friedman / datamule-python

A package to work with SEC data. Incorporates datamule endpoints.
MIT License
73 stars 7 forks source link

Date formatting for downloads #12

Closed AnirudhJM24 closed 3 weeks ago

AnirudhJM24 commented 3 weeks ago

Hi @john-friedman,

I have taken care of issue - https://github.com/john-friedman/datamule-python/issues/11

Heres an example

downloader = dm.Downloader()

downloader.download(form='10-K', ticker=['TSLA'], output_dir='filings')

filings downloaded -

image

john-friedman commented 3 weeks ago

Hi @AnirudhJM24, thank you for the pull request. I ended up integrating your code manually (in a bit of a rush, and there was an issue with previous form d commits that I did not want to integrate yet). I've added you to the contributors.md

john-friedman commented 3 weeks ago

(To be clear this is because I don't know how git works w.r.t. approving some modifications but not others, this is something I need to learn, and I plan to this weekend)

AnirudhJM24 commented 2 weeks ago

(To be clear this is because I don't know how git works w.r.t. approving some modifications but not others, this is something I need to learn, and I plan to this weekend)

Hi @john-friedman

No issues, it was a mistake from my end, I created a branch from the old PR branch