Flake8-pyproject doesn't work with flake8 `6.1.0`

john-hen / Flake8-pyproject

Flake8 plug-in loading the configuration from pyproject.toml

https://pypi.org/project/Flake8-pyproject

MIT License

227 stars 10 forks source link

Flake8-pyproject doesn't work with flake8 `6.1.0` #22

Closed elevans closed 1 year ago

elevans commented 1 year ago

flake8 version 6.1.0 was recently released on conda forge but unfortunately seems to be incompatible with flake8-pyproject version 1.2.3. With version 6.1.0 my configuration in my pyproject.toml are ignored. Downgrading to 6.0.0 resolves this issue.

john-hen commented 1 year ago

I don't see that in the nightly tests. The first run with Flake8 6.1.0 (three days ago) as well as all subsequent runs passed, just like the last run with Flake8 6.0.0.

I also cannot reproduce that locally: with Python 3.11, Flake8 6.1.0, Flake8-pyproject 1.2.3, on Windows. Though everything is installed directly via Pip, not Conda.

elevans commented 1 year ago

Hi @john-hen,

Thanks for the quick reply. I went back and tested again and things seem to be okay with 6.1.0. Our CI jobs were failing and it was pointing in this direction...but clearly that was wrong! Sorry about that. I'm closing this issue.

Cheers,

-Ed