john-kelly / elm-postgrest

Make PostgREST requests in Elm
109 stars 14 forks source link

QueryParams Data Structure Refactor #21

Closed john-kelly closed 7 years ago

john-kelly commented 7 years ago
type Select = Nested | Simple 

i dont think that i makes sense for this to be a sum type. there may very well be no benefit from this.

john-kelly commented 7 years ago

type Query uniq schema a
    = Query schema Parameters (Decode.Decoder a)

type Parameters
    = Parameters
        { name : String
        , select : List String
        , order : List OrderBy
        , filter : List Filter
        , limit : Limit
        , nested : List Parameters
        }

or even

type Parameters
    = Parameters
        { name : String
        , select : List String
        , order : List OrderBy
        , filter : List Filter
        , limit : Limit
        }
        (List Parameters)

NOTE: List String vs List Select... where Select is just type Select = Select String