john-kelly / elm-postgrest

Make PostgREST requests in Elm
109 stars 14 forks source link

Should offset be just an Int? #39

Closed randomer closed 7 years ago

randomer commented 7 years ago

So instead of Nothing it would simply be 0

john-kelly commented 7 years ago

this is a good point.

it's almost a case for bringing back opaque Limit and Offset 👍 It might be a bit weird that the options type would look like:


{ filters: ...
, orders: ...
, limit: Maybe Int
, offset: Int
}

I'm not convinced either way tho.

john-kelly commented 7 years ago

This may provide some insight: https://www.postgresql.org/docs/9.6/static/queries-limit.html

anderoonies commented 7 years ago

agreed