Add Travis CI integration

john-kelly / elm-postgrest

Make PostgREST requests in Elm

109 stars 14 forks source link

Closed danstn closed 7 years ago

danstn commented 7 years ago

This PR Build Status:

... and a "self-documenting" Makefile:

$ make
install    Install build dependencies and packages
build      Build
test       Run unit tests

For #4.

danstn commented 7 years ago

Should probably use a specific version of Node instead (example travis setup).

john-kelly commented 7 years ago

Great. I'll take a look tonight after work. 👍 for using elm-css as a guide.

john-kelly commented 7 years ago

Additionally, what are your thoughts on this travis setup: https://github.com/krisajenkins/remotedata

I'd be happy to not introduce node-test-runner if we don't have to. I suppose it's not that big of a deal though.

I'll keep playing with this though and let you know what I think.

danstn commented 7 years ago

Test runner blows up on Promises (cause of node version I think).

Not really sure what's the best way to go about it. elm-test worked fine for me in the past so I just went for it.

john-kelly commented 7 years ago

I looked at a few more examples and it looks like you implemented the "best practice" test suite. I think this is good to go 👍