john-kurkowski / tldextract

Accurately separates a URL’s subdomain, domain, and public suffix, using the Public Suffix List (PSL).
BSD 3-Clause "New" or "Revised" License
1.81k stars 211 forks source link

Parsing without PSL still uses PSL for some FQDNs #262

Closed jonmartz closed 2 years ago

jonmartz commented 2 years ago

Hi, we ran into the following issue:

Thanks!

john-kurkowski commented 2 years ago

without PSL

I think you're reading the include_psl_private_domains parameter as controlling whether this project uses the PSL to parse domains, or uses something else to parse domains. The parameter actually controls whether PSL private domains are distinguished from public domains. See this section of the README. The rule for kawasaki.jp occurs early in the list, so it is not in the private domain section, and wouldn't be affected by the parameter.

jonmartz commented 2 years ago

Thank you very much for the quick response, which resolves our issue.