search

john30 / ebusd-configuration

ebusd configuration files
GNU General Public License v3.0
173 stars 271 forks source link

scanconfig picks wrong CSV #400

Open jonathanschneider opened 4 months ago

jonathanschneider commented 4 months ago

Hello, I have a Vaillant heater with the article number 0010009351. Looking at 08.bai.HW7401.csv, I would assume that bai.0010003886.inc gets picked because of line 8.

Instead bai.0010006101.inc gets picked because of line 12.

  1. How does ebusd determine the product and is there a way to check what product ebusd actually uses to pick the CSV in this file?
  2. If I am missing definitions in the picked CSV, would it make more sense to add those definitions to that CSV or try to alter which CSV gets picked? bai.0010003886.inc includes the definitions I require.

Thanks!

JonesGW-MGD commented 4 months ago
  1. You can check the product ID by either checking your logs on start up, you should see something like:
2024-02-23 17:30:12.073 [update notice] sent scan-read scan.08 id QQ=31: 21;22;46;0010017064;1300;806453;N4

so mine is 0010017064

or you can run 

ebusctl scan 08

How you do that depends a bit on how you are running ebusd

  1. I think if you have the configurations cloned locally it doesn't really matter which method you chose to help ebusd pick the 'richest' config file - but I'm a relative novice and others may disagree. I guess you need to think about future proofing and how you might assimilate changes that might get added to the config files that might fill in more and more gaps for you over time? Maybe in your scenario, I'd edit 08.bai.csv so the product ID matches the file you want it to pick?

What by the way is 08.bai.HW7401.csv? (maybe a mis link?)

(If you do have HW7401, and you go through 08.bai.csv and it doesn't match a product ID I'd assume it would pick the default bai.308523.inc at hardware fallback line 28?)

jonathanschneider commented 4 months ago

Thanks! That was a great hint because neither the logs nor the ebusctl scan 08 output the product ID. All I get is 08;Vaillant;BAI00;0518;7401;;;;;;; and that would explain why 08.bai.csv (I named the v2.x.x file but the link was correct) picks another inc. Since I know my product ID I think I will add the definitions to that inc and manipulate 08.bai.csv to pick that. Thanks again!

jonathanschneider commented 4 months ago

OK, here's my attempt to fix the issue: #401

JonesGW-MGD commented 4 months ago

Glad to help in a small way - all the best! But are you saying that your device ID is not correctly being received from a broadcast request by ebusd?