Add "replace" option

[GoogleCodeExporter]

I'm using sipdroid with netvoip.ch. All my phone numbers are stored in the
"+41xxxxxxxxx" format. Netvoip.ch does not accept this format and I need to
replace the number with "0041xxxxxxxxx" before calling.

I contacted netvoip.ch and they told me that they have not planned to
support this "feature"!?

So I would really appreciate a "replace" feature in sipdroid. It could be
based on regular expressions. Something like:

Replace: ^\+41(.*)$
With: 0041\1

Original issue reported on code.google.com by cyril.ja...@gmail.com on 16 Jul 2009 at 1:38

[GoogleCodeExporter]

Going thru PBXes would be a possible solution.

Original comment by pmerl...@googlemail.com on 16 Jul 2009 at 2:19

• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

I know this but I prefer to have only one account. Would you accept a patch?

Original comment by cyril.ja...@gmail.com on 16 Jul 2009 at 2:25

[GoogleCodeExporter]

Yes, please outline what you want to change, and I will add you as a member to 
check it 
in.

Original comment by pmerl...@googlemail.com on 16 Jul 2009 at 2:59

[GoogleCodeExporter]

I think we could extend (replace) the prefix option with a replace feature. 
Then the
prefix option would be:

Replace: (.*)
With: 123\1

So that we have a more flexible solution.

GUI

* Rename "Prefix" to "Adapt phone number" (or something similar)
* Create a dialog with 2 edit field: "Search pattern" and "Replace with"
* If possible add help about regular expressions

Core

* Add 2 new preferences "adaptsearch" and "adaptreplace"
* Implement the match/replace function in the Caller class ("prefix" is done 
there so
I guess this would be the right place. Do phone numbers entered in sipdroid 
directly
also come here?)
* Automatically migrate the "prefix" option

Original comment by cyril.ja...@gmail.com on 16 Jul 2009 at 3:34

[GoogleCodeExporter]

These preferences can be collapsed into one field (Replace Pattern), by taking 
in
input in the format (replacePattern,withPattern), parsing the input and then 
applying
the transformation.

Will save screen real estate and reduce clutter...

Original comment by wavehill09@gmail.com on 16 Jul 2009 at 9:05

[GoogleCodeExporter]

Indeed. IMHO this would be less user-friendly. But regular expressions are 
already a
nightmare for standard users ;) And this will simply the implementation a lot.

I found 3 references to SipdroidEngine#call. I guess the only one that needs to 
be
modified is in Caller#onReceive. I think the value typed by the user in sipdroid
should be used as this. Is SIPUri still needed?

wavehill09, do you mind if I change your "prefix" feature? Or do you want to do 
it?

Original comment by cyril.ja...@gmail.com on 16 Jul 2009 at 9:32

[GoogleCodeExporter]

I've added cyril as a member.

Original comment by pmerl...@googlemail.com on 16 Jul 2009 at 9:51

[GoogleCodeExporter]

Please go ahead and change it.

Original comment by mntwoo...@gmail.com on 16 Jul 2009 at 10:52

[GoogleCodeExporter]

Original comment by pmerl...@googlemail.com on 16 Jul 2009 at 11:52

• Changed state: Started

[GoogleCodeExporter]

Accepted Cyril's patch. Thank you!

Original comment by pmerl...@googlemail.com on 22 Jul 2009 at 9:55

• Changed state: Fixed

[GoogleCodeExporter]

I use (.*),3651\1 for adding 3651 (for french private calls).

Now an old bug (from prefix option) is back: how do I call twice a number 
without
adding twice the prefix?

Original comment by Murphy2...@gmail.com on 20 Aug 2009 at 1:41