john990 / sipdroid

Automatically exported from code.google.com/p/sipdroid
GNU General Public License v3.0
0 stars 0 forks source link

WiFi sleep policy bug (introduced in r182) #95

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi,

I have an issue with the WiFi sleep policy thing which was introduced in r182.

In fact, Sipdroid keeps changing my settings without asking me, in a
periodic way.

That means, I can't change my settings because they would be erased by
Sipdroid, each time updateSleep() is called.

That's *REALLY*REALLY*REALLY* annoying, especially when the WiFi setting is
off on Sipdroid : I can't have my WiFi sleep policy to "Never" because
Sipdroid sets it to "Always" just because he thinks he's smarter than me,
and even if sometimes I have doubts, generally I would think that's kind of
false.

As I go on vacation tomorrow, I don't really have the time to write a patch
(in fact, I installed a pre-r182 release).

Thanks!

Btw, I use the Market version. I saw it's counting in the *huge* if line
(at l.351), but I'm too tired to play with Boole right now :)

Original issue reported on code.google.com by alexis.r...@gmail.com on 25 Jul 2009 at 2:14

GoogleCodeExporter commented 8 years ago
Just thinking about it, would it be better to show a popup saying "if you check 
WLAN,
i need to set the WiFi policy to 'Never'. do you agree ?", and don't set it to
"Always" is WLAN option is disabled ?

Maybe a bad idea...

Original comment by alexis.r...@gmail.com on 25 Jul 2009 at 2:16

GoogleCodeExporter commented 8 years ago
Before r182 Sipdroid set it to "Never" regardless of what options you chose. So 
it has 
already been improved to use the default mode whenever it makes sense.

Original comment by pmerl...@googlemail.com on 25 Jul 2009 at 6:23

GoogleCodeExporter commented 8 years ago
I have this same issue.  Whenever I put my HTC Magic to sleep, Sipdroid (I 
assume
based on the content of this thread) changes my Wifi sleep policy from "Never" 
to
"Always" and my phone switches to 3G.  Why does Sipdroid need to change the Wifi
sleep policy at all?  I would prefer that my setting ("Never") never be changed.

Original comment by anders...@gmail.com on 1 Aug 2009 at 7:35

GoogleCodeExporter commented 8 years ago
Couldn't this also cause problems with incoming calls?  For example, couldn't 
the
following happen?

1) Phone is using WiFi
2) Phone goes into sleep mode
3) Phone switches to 3G (due to WiFi sleep policy determined by Sipdroid)
4) Incoming call wakes up phone and call is accepted
5) Phone switches to WiFi and connection with call is lost

Original comment by anders...@gmail.com on 1 Aug 2009 at 8:38

GoogleCodeExporter commented 8 years ago
The option within Sipdroid is called "WLAN active". When setting it to "Level 
<= 4 
bars" it will never sleep.

Original comment by pmerl...@googlemail.com on 8 Aug 2009 at 4:45

GoogleCodeExporter commented 8 years ago
I have an HTC Hero and found that Sipdroid always disables the wi-fi sleep 
override policy. This makes the auto-
sync with Google applications have problems since the wi-fi always gets 
disabled.

After I uninstalled Sipdroid, the phone's wi-fi sleep policy was retained.

Original comment by joseph.c...@gmail.com on 14 Aug 2009 at 2:20

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
oh i'm so glad i found this. this bug was really driving me nuts. nobody else 
seemd
to have this bug and i tried everything to get the wifi sleep policy working. 
now
after deinstalling sipdroid everything works fine again. it's a pitty that i 
had to
deinstall it but the autosyncing of my newsrob is more important to me at the 
moment.

would be great if this bug could be solved.

Original comment by christop...@gmail.com on 3 Sep 2009 at 4:36

GoogleCodeExporter commented 8 years ago
It would be great so that I could leave it installed and use VOIP on my Android 
phone! Please fix!

Original comment by joseph.c...@gmail.com on 3 Sep 2009 at 4:42

GoogleCodeExporter commented 8 years ago
The next release will touch sleep policy only when settings are changed, and 
inform the 
user about it.

The "WLAN active" option will be removed.

Original comment by pmerl...@googlemail.com on 10 Sep 2009 at 8:14

GoogleCodeExporter commented 8 years ago
First of all, I'm glad to know that the issue is being addressed--thank you for 
that. However, since this sleep 
policy setting is a global, advanced wifi setting, I don't understand why 
Sipdroid will "touch" it at all. All 
applications, including Sipdroid, should behave using whatever global setting 
is in place. I can't think of a 
scenario where I would want an application to change this. Can you just have 
Sipdroid obey the sleep policy and 
never change it? After all, this affects all applications on the device.

Original comment by joseph.c...@gmail.com on 10 Sep 2009 at 4:30

GoogleCodeExporter commented 8 years ago
I have two reasons for that:

1) The Wifi sleep policy is an advanced setting that the end-user cannot easily 
set 
correctly. First he needs to know of the existance of the setting, think of in 
which 
cases he is allowed to save battery and when he needs wireless LAN active for 
staying 
registered. The update tells the user during setup. So if he wants to override 
that 
is no problem at all.

2) On initial 1.5 firmware there was no such setting accessible to the user. So 
the 
application had to set it. This firmware is still around on many devices.

Original comment by pmerl...@googlemail.com on 10 Sep 2009 at 10:27

GoogleCodeExporter commented 8 years ago

Original comment by pmerl...@googlemail.com on 21 Sep 2009 at 11:15