search

johnHackworth / goblin

GNU Affero General Public License v3.0
50 stars 4 forks source link

500 error from link preview, link itself works fine #77

Open sirilyan opened 7 months ago

sirilyan commented 7 months ago

https://kobold.page/notes/9s6fn09kaceqzg2y

image

sirilyan commented 7 months ago

The link in the note goes to the right URL, but the link in the preview underneath (the one that's 500ing) has trimmed the dash at the end.

Probably the regex that pulls out the url is too picky and won't let a URL end in a dash.

Sammy99jsp commented 6 months ago

You are correct !

https://github.com/johnHackworth/goblin/blob/690fb6c6487112018c2a2673271942e3388a03fd/packages/client/src/components/MkNote.vue#L263

Sammy99jsp commented 6 months ago

Should this sort of stuff be done in-house, or would it be worth considering using an external implementation?