johnabel / gillespy

A Python package for stochastic model building and simulation. Published as Abel et al., IEEE Life Sci Lett 2017.
https://dx.doi.org/10.1109/LLS.2017.2652448
GNU General Public License v3.0
6 stars 17 forks source link

GillspySolver can't use a negative seed #13

Open ahellander opened 9 years ago

ahellander commented 9 years ago

Not sure if this is a bug or not, but it should be documented. It causes a problem for molnsutil, which generates negative seed bases.

johnabel commented 9 years ago

Noted, this will be documented. I believe this is true of StochKit2 as well?

On Fri, Jul 3, 2015 at 1:12 AM, Andreas Hellander notifications@github.com wrote:

Not sure if this is a bug or not, but it should be documented. It causes a problem for molnsutil, which generates negative seed bases.

— Reply to this email directly or view it on GitHub https://github.com/JohnAbel/gillespy/issues/13.

John H. Abel PhD Candidate, Systems Biology Harvard University Email: j jha@engr.ucsb.eduohnhabel@g.harvard.edu Tel: (401)787-4253

ahellander commented 9 years ago

I assume the problem is really StochKit. Negative I could live with, but now it doesn't seem to support 64-bit integers. This is annoying.

ahellander commented 9 years ago

I can reflect the seed_base in molnsutil to make it positive (@briandrawert, right??) but I will handle the 64-bit issue in Gillespy instead.

ahellander commented 9 years ago

This is fixed in the outstanding PR