search

johnagan / clean-webpack-plugin

A webpack plugin to remove your build folder(s) before building
MIT License
1.96k stars 135 forks source link

Remove duplicate `dry` from readme #113

Closed mkungla closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #113 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files           1        1           
  Lines          74       74           
  Branches       25       25           
=======================================
  Hits           73       73           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0f798a...8fbf1f4. Read the comment docs.

chrisblossom commented 5 years ago

Thanks for the PR, but this isn't a duplicate dry entry. It is there as an example because it is required when using dangerouslyAllowCleanPatternsOutsideProject.

mkungla commented 5 years ago

@chrisblossom aight. There could be a comment at least then, right now you have there something which can be read as duplicate key. You have dry at the beginning of that example and dry after dangerouslyAllowCleanPatternsOutsideProject