johnagan / clean-webpack-plugin

A webpack plugin to remove your build folder(s) before building
MIT License
1.96k stars 137 forks source link

use afterCompile hook for cleanOnceBeforeBuildPatterns #151

Closed chrisblossom closed 5 years ago

chrisblossom commented 5 years ago

Why: works better with other plugins so plugin order shouldn't matter.

Since this happens before emit, it is not a breaking change.

Fixes #150 and maybe #146.

codecov-io commented 5 years ago

Codecov Report

Merging #151 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files           1        1           
  Lines          88       88           
  Branches       30       30           
=======================================
  Hits           87       87           
  Misses          1        1
Impacted Files Coverage Δ
src/clean-webpack-plugin.ts 98.86% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fd2f73...7f55e7d. Read the comment docs.