johnbabu021 / shopping-cart

React hooks Firebase tailwindcss
https://e-commerce-app-ql089sf70-johnbabu021.vercel.app/
MIT License
6 stars 10 forks source link

Add Dark Mode #23

Closed iqbalutomo closed 3 years ago

iqbalutomo commented 3 years ago

I have implemented the dark mode feature in the app, hope this helps. #22

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

shopping-cart – ./

🔍 Inspect: https://vercel.com/johnbabu021/shopping-cart/E4vXei7KyKybrKpPVGqcN81w6XXb
✅ Preview: https://shopping-cart-git-fork-iqbalutomo-develop-darkmode-johnbabu021.vercel.app

e-commerce-app – ./

🔍 Inspect: https://vercel.com/johnbabu021/e-commerce-app/9TVHSWivkEWdUVhmUojxgmxC1aDi
✅ Preview: https://e-commerce-app-git-fork-iqbalutomo-develop-darkmode-johnbabu021.vercel.app

johnbabu021 commented 3 years ago

Ok but we have a problem Change white background color including loading skeleton To white

iqbalutomo commented 3 years ago

sorry can you explain which part is meant by loading skeleton?

iqbalutomo commented 3 years ago

i will fix it, but can you tell me in which component or on what page?

johnbabu021 commented 3 years ago

Sidebar selector Quantity selector Some more in product details page

johnbabu021 commented 3 years ago

Screenshot_2021-10-05-14-14-43-779_com android chrome

iqbalutomo commented 3 years ago

Ok, do you mean i have to fix the sidebar button background color? and also the input background color becomes transparent?

iqbalutomo commented 3 years ago

Ok i try to fix it soon

johnbabu021 commented 3 years ago

Yes