search

johnbenedictyan / pe

0 stars 0 forks source link

Edit Roles Bug #2

Open johnbenedictyan opened 1 year ago

johnbenedictyan commented 1 year ago

Bug Report

What Happened:

Steps to reproduce:

  1. roles 3 roles/Coordinator, Tutor
  2. show 3

Screenshots

Screenshot 2022-11-11 at 4.23.07 PM.png

Screenshot 2022-11-11 at 4.23.14 PM.png

soc-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to change the role of the prof with the role command

Screenshot 2022-11-11 at 4.54.55 PM.png

Screenshot 2022-11-11 at 4.55.50 PM.png

Using the example given in the app, in screenshot 2, we see that in screenshot 1, the roles of the professor remain as unassigned. This might be a UI bug but it causes a lot of problems especially when people want to look up for the roles of the prof as see it as unassigned. As such, I have given this a medium severity as looking up information is one of the basic features of this app should accomplish properly and that many people will be checking this information out. In addition, in the event that only 1 role can be assigned, an error message should be thrown instead of the command being accepted.

[original: nus-cs2103-AY2223S1/pe-interim#3649] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for pointing this out. Yes, in fact only 1 role can be assigned, and not multiple. This is stated in the UG

Screenshot 2022-11-14 at 4.08.18 PM.png

However, we recognise that we have outputted an incorrect error message here. We, however disagree that it is of medium severity. A user that has read the user guide will not try to input multiple roles for professors, as such it will only cause minor inconveniences in rare situations and will not affect normal operations of the product

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Features that work as specified by the UG but should have been designed to work differently (from the end-user's point of view) fall in this category too. - Definition of feature flaw

Although it is stated in the UG that only one role is accepted, the feature of changing the state to assigned is both a functionality bug and a feature bug in this case. It is a functionality bug because there is no mention in the UG that this state change to unassigned would occur.

It is a feature flaw because it should have been designed differently to give an error command or at the very least not change the state of the professor. It is also a feature flaw because there are very real instances whereby a professor is both the coordinator and the professor of a module.

It is a medium-level bug because of these reasons and it will provide occasional inconvenience to users regardless of whether they read the UG or not.