Open johnbenedictyan opened 1 year ago
This is a feature and not a flaw.
We allow freedom in the naming of tutorial groups as they can come in different forms. For example in CS2100, it is indicated as a 'T' followed by a number (eg. T02), but for modules like CS1101S, there is a letter behind it (eg. T07B). There are so many modules in NUS and the possible combination of tutorial group names are endless. Therefore, applying any further restrictions to the tutorial group will be an 'Overzealous input validation' and we do not want that.
If your issue specifically is that you can add a tag of CS2103T-CS2103T
where the module and the tutorial group are the same, our team feels adding a check for that is unnecessary as a rational user would not do this
Team chose [response.Rejected
]
Reason for disagreement: [replace this with your explanation]
Bug Report:
What Happened:
Tags: {Alphanumeric Module}-{Alphanumeric Tutorial group}
CS2103T-CS2103T
which does not seem to fit as the module code is allowed to be the tutorial group.Steps to reproduce:
add n/john2 s/o asd p/123123123123 e/asd@asd.com pos/Professor a/123 t/CS2103T-CS2103T
Screenshots
Screenshot 2022-11-11 at 4.38.52 PM