search

johnbillion / extended-cpts

A library which provides extended functionality to WordPress custom post types and taxonomies.
GNU General Public License v2.0
974 stars 97 forks source link

wp-browser composer patch is no longer valid when running `composer install` #197

Closed defunctl closed 2 years ago

defunctl commented 2 years ago

Hey John,

Running composer install results in:

  Applying patches for lucatume/wp-browser
    tests/patches/wp-browser-554.patch (https://github.com/lucatume/wp-browser/issues/554)
   Could not apply patch! Skipping. The error was: Cannot apply patch tests/patches/wp-browser-554.patch

As there's no composer.lock file, not sure which version you were patching but it's no longer valid and it does look like https://github.com/lucatume/wp-browser/issues/554 is fixed as of 3.0.22.

In addition to this, if you use this library in another project with composer patching enabled, it fails because the tests folder is ignored on export, so the patch doesn't exist to apply.

Any chance you're able to remove the patch or use a github .patch URL instead (if there's an upstream bug that still needs fixing) so it doesn't even need to exist in your repo?

Thanks!