search

johnbillion / extended-cpts

A library which provides extended functionality to WordPress custom post types and taxonomies.
GNU General Public License v2.0
979 stars 96 forks source link

Update composer file #74

Closed vinkla closed 7 years ago

vinkla commented 7 years ago

I've updated and formatted the composer.json file. Also updated the packages constraints.

johnbillion commented 7 years ago

The test suite isn't compatible with PHPUnit 6 just yet.

vinkla commented 7 years ago

I've updated the PHPUnit version.

johnbillion commented 7 years ago

Thanks. Do you have a link to some documentation about preferring the caret ^ over the tilde ~?

vinkla commented 7 years ago

Here you go: Caret Version Range.

vinkla commented 7 years ago

You definitely want the ^ for the PHP version since >= means we support PHP 8.0. We don't know if this package works with 8.0 just yet.

johnbillion commented 7 years ago

The indentation in this file seems to have gone weird. It's using three spaces for indentation.

vinkla commented 7 years ago

I've fixed the indentation and added a .editorconfig file.

vinkla commented 7 years ago

@johnbillion I've fixed the conflicts.

vinkla commented 7 years ago

Any update on this pull request?

johnbillion commented 7 years ago

Cheers @vinkla, I'll get this in to the next version.

vinkla commented 7 years ago

@johnbillion great!

vinkla commented 7 years ago

@johnbillion make you could merge this and then take a look at it before releasing the next version?

This pull request basically just updates the syntax.