search

johnbillion / query-monitor

The developer tools panel for WordPress
https://querymonitor.com
GNU General Public License v2.0
1.6k stars 211 forks source link

Improve QM_Output_Html #736

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

These changes have no name! Maybe "Adding new PHP features"?

szepeviktor commented 1 year ago

Having no template engine in WordPress makes me sad ... or use Timber.

Mixing programming languages in one file makes me realize I'm slow at context switching. Although HTML is not a language!

szepeviktor commented 1 year ago

Mixing programming languages

John! A new section in https://github.com/szepeviktor/very-clean-code 🎉

🔴 Mixing programming languages

Make low-level libraries connect different languages.

crstauf commented 1 year ago

I'm personally not a fan of ternary operators, as it makes code less clear and reading and comprehension slower, especially for junior developers.

szepeviktor commented 1 year ago

especially for junior developers

I agree with you. When I see a warning ⚠️ Junior Developers I quickly run away 🐰

johnbillion commented 1 year ago

Thanks for the PR Viktor but I'm going to close this off as I'm trying to minimise non-functional changes at the moment. Cheers!

szepeviktor commented 1 year ago

Okay. I'm a non-functional change generator.