Open siliconforks opened 3 months ago
Also encountered this error.
The problem is that target array items on Windows actual value is not
O:/Apache24/htdocs/wordpress/wp-content/themes/twentytwentyfour/parts/header.html
, but
O:\Apache24\htdocs\wordpress/wp-content/themes/twentytwentyfour/parts/header.html
The plugin should use wp_normalize_path
when forming this array.
The plugin should use
wp_normalize_path
when forming this array.
That's what QM_Util::standard_dir
does (among other things). Query Monitor performs
$file = QM_Util::standard_dir( $file );
but it does it too late, because it has already used $file
before then.
When running Query Monitor with the Twenty Twenty-Four theme on Windows I get these warnings:
I believe the cause of the issue is here:
https://github.com/johnbillion/query-monitor/blob/3.16.0/collectors/theme.php#L473-L500
Note the following:
$this->data->count_template_parts[ $file ]
uses$file
before callingQM_Util::standard_dir
$this->data->template_parts[ $file ]
and$this->data->theme_template_parts[ $file ]
use$file
after callingQM_Util::standard_dir
So,
$this->data->count_template_parts
does not have the same keys as the other arrays.