johnbillion / query-monitor

The developer tools panel for WordPress
https://querymonitor.com
GNU General Public License v2.0
1.58k stars 207 forks source link

PHP8.4 alpha 1 warnings - nullable is deprecated, the explicit nullable type must be used instead #873

Closed ipajen closed 1 month ago

ipajen commented 1 month ago

Environment

Maybe bit early but PHP 8.4 alpha1 has been released

PHP 8.4.0alpha1

PHP 8.4: Implicitly nullable parameter declarations deprecated implicitly-marking-parameter-type-nullable-deprecated

`__construct(): Implicitly marking parameter $trace as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\query-monitor\classes\Backtrace.php on line 136

Deprecated: QM_Collector_HTTP::action_curl_after_request(): Implicitly marking parameter $info as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\query-monitor\collectors\http.php on line 262

Deprecated: QM_Collector_HTTP::action_fsockopen_after_request(): Implicitly marking parameter $info as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\query-monitor\collectors\http.php on line 271

Deprecated: QM_Collector_Logger::store(): Implicitly marking parameter $prefix as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\query-monitor\collectors\logger.php on line 210

Deprecated: QM_Collector_Logger::interpolate(): Implicitly marking parameter $prefix as nullable is deprecated, the explicit nullable type must be used instead in C:\wamp64\www\wp\wp-content\plugins\query-monitor\collectors\logger.php on line 262`

Thank you!

johnbillion commented 1 month ago

Thanks! I'll add testing for 8.4 soon.