search

johnboiles / obs-mac-virtualcam

ARCHIVED! This plugin is officially a part of OBS as of version 26.1. See note below for info on upgrading. 🎉🎉🎉Creates a virtual webcam device from the output of OBS. Especially useful for streaming smooth, composited video into Zoom, Hangouts, Jitsi etc. Like CatxFish/obs-virtualcam but for macOS.
GNU General Public License v2.0
4.07k stars 161 forks source link

[Feature Request] Rename Source Classes #215

Closed genkiyooka closed 3 years ago

genkiyooka commented 4 years ago

Describe the bug CMIO DAL plug-ins are dylibs loaded into the client's address space. All Objective-C classes within a single process utilize a single shared namespace. Therefore, the ObjC classnames ideally should be disambiguated from other classes using a prefixing scheme or similar. I would suggestion something like JBOBSMacVirtualCamStream instead of Stream and so forth.

gxalpha commented 4 years ago

This is interesting. Could you link further documentation regarding this?

johnboiles commented 4 years ago

That makes sense to me in theory! But i'd be a little surprised if the system didn't handle this somehow (is there anyway to add namespaces when loading dylibs/plugins?). And I seem to remember I've run this plugin alongside the boilerplate example I made which has the same class names. It'd be nice to repro this and prove it's actually an issue before we make the names ugly :)

johnboiles commented 3 years ago

Yeah as we figured out in #232 this was definitely a real problem. Thanks for reporting @genkiyooka!

johnboiles commented 3 years ago

This is done in #242