search

johnboiles / obs-mac-virtualcam

ARCHIVED! This plugin is officially a part of OBS as of version 26.1. See note below for info on upgrading. 🎉🎉🎉Creates a virtual webcam device from the output of OBS. Especially useful for streaming smooth, composited video into Zoom, Hangouts, Jitsi etc. Like CatxFish/obs-virtualcam but for macOS.
GNU General Public License v2.0
4.06k stars 160 forks source link

Try to use `CVPixelBufferGetBaseAddressOfPlane` #230

Closed johnboiles closed 4 years ago

johnboiles commented 4 years ago

This change uses CVPixelBufferGetBaseAddressOfPlane instead of CVPixelBufferGetBaseAddress to get the base memory address to copy the framebuffer into. Hopefully this will fix the intermittent skewed output bug in johnboiles/obs-mac-virtualcam#160.

I've never been able to reproduce this personally so I can't validate this fix. But it seems like the more right API to use. 🤞

Assuming https://github.com/johnboiles/obs-mac-virtualcam/pull/229 fixed the build, the build on this PR should produce a signed pkg we can use to test this change.

johnboiles commented 4 years ago

Tried it out and it worked for me!