search

johnboiles / obs-mac-virtualcam

ARCHIVED! This plugin is officially a part of OBS as of version 26.1. See note below for info on upgrading. 🎉🎉🎉Creates a virtual webcam device from the output of OBS. Especially useful for streaming smooth, composited video into Zoom, Hangouts, Jitsi etc. Like CatxFish/obs-virtualcam but for macOS.
GNU General Public License v2.0
4.07k stars 161 forks source link

Make class names more unique to prevent namespace collisions #242

Closed johnboiles closed 3 years ago

johnboiles commented 3 years ago

Closes #232 and #215. Also corresponds to this change from @PatTheMav in the main OBS codebase.

Because ObjectiveC doesn't have namespacing, if any other plugin is loaded and has the same symbol names, one or both of the plugins may not work. This happened with the Canon EOS Webcam utility which appears to also be based off of my code.

This makes the namespaces more unique.

PatTheMav commented 3 years ago

Just FYI - MachServer also needs to be namespaced, I missed that one in my PR.

gxalpha commented 3 years ago

Shall I create a PR? Or are you doing one?

PatTheMav commented 3 years ago

@gxalpha Go ahead, I'm swamped with CEF stuff right now.. 😂

johnboiles commented 3 years ago

Does it need to be namespaced just in case other OBS plugins use the naming MachServer?

johnboiles commented 3 years ago

@gxalpha if you wanted to knock that out, that'd be awesome!!

PatTheMav commented 3 years ago

True, in this specific case it interferes only with this plugin right here (because it's in the OBS plugin, not the DAL plugin). By that token it might be a non-issue once you archive this plugin.

johnboiles commented 3 years ago

Yeah def worth doing. It's more correct, can't hurt, and might avoid future issues.