search

johnbrett / hapi-auth-bearer-token

Simple Bearer authentication scheme plugin for hapi, accepts token by Header, Cookie or Query parameter.
MIT License
218 stars 46 forks source link

Disable query token by default fixes #98 #122

Closed AdriVanHoudt closed 7 years ago

johnbrett commented 7 years ago

Thanks for the work on this @AdriVanHoudt. I think it might be best to hold on this until there are some other breaking changes, should they pop up. Does that sound ok to you? Happy to proceed if you feel it's important though!

AdriVanHoudt commented 7 years ago

Well you can consider the update of joi breaking and I don't see any other issues or features coming up so personally I would do a release.

johnbrett commented 7 years ago

Is the update of joi breaking? Or just that we've updated a major version of joi?

AdriVanHoudt commented 7 years ago

we have updated a major version of joi which did changes to .boolean() and technically it could break when people pass 1 or 'true' (the string) to set allowQueryToken for example. Now I would expect people to not do that but you know ^^

johnbrett commented 7 years ago

Thanks for this @AdriVanHoudt - sorry for taking so long to publish!

AdriVanHoudt commented 7 years ago

NP! 🚀

AdriVanHoudt commented 7 years ago

@johnbrett did you forget to push the commit for the 5.0.0 release? I see npm telling me there is a 5.0.0 release but I don't see anything 5 related in the repo :P

johnbrett commented 7 years ago

I 100% forgot to push the commit to the repo @AdriVanHoudt. I don't do as much open source these days, I'm seriously off my game!!