search

johnbrett / hapi-auth-bearer-token

Simple Bearer authentication scheme plugin for hapi, accepts token by Header, Cookie or Query parameter.
MIT License
218 stars 46 forks source link

Remove .vscode and add changelog #135

Closed RicardoGeek closed 7 years ago

RicardoGeek commented 7 years ago

Remove .vscode from versioning and add it go .gitignore Add a changelog to the project :)

AdriVanHoudt commented 7 years ago

A PR for removing the .vscode folder is welcome (unless @johnbrett has an actual reason to have it in the repo?) The changelog is up to him as well ^^

johnbrett commented 7 years ago

Hi @RicardoGeek,

My reasoning behind the .vscode, I leave that in my projects so anyone who wants to debug tests have the option to do so on opening of the repo easily, just open project in vscode, set a breakpoint, run. No need to configure launch files etc. I see no real downsides of this being there - but happy to listen any complaints or reasoning why it should be removed.

I could see reasoning to adding it to an npm ignore, and would accept that a PR on that though.

On the changelog, I think as this module has so few changes, and no expected new features on the roadmap it would be unnecessary overhead.

Thanks for the early reply also @AdriVanHoudt 👍