search

johnbrett / hapi-auth-bearer-token

Simple Bearer authentication scheme plugin for hapi, accepts token by Header, Cookie or Query parameter.
MIT License
218 stars 46 forks source link

Fix pr-129 conflicts #136

Closed johnbrett closed 6 years ago

johnbrett commented 7 years ago

This will close https://github.com/johnbrett/hapi-auth-bearer-token/issues/124.

To view diff, use this link: https://github.com/johnbrett/hapi-auth-bearer-token/pull/136/commits/36f77ad77e8dd658306add413d3da3f9202ad221?w=1 (thanks for this tip @AdriVanHoudt)

AdriVanHoudt commented 7 years ago

Wait is this for https://github.com/johnbrett/hapi-auth-bearer-token/pull/129 or #124 ?

johnbrett commented 6 years ago

this PR fell down due to my inactivity - my bad @nakardo. Are you still looking for this feature? We have just released a new version of this module with support for v17, so will have to redo this PR to fit that, but I'm happy to take that on if you're still looking for it.

nakardo commented 6 years ago

@johnbrett No problem. I currently don't own anymore the project I was working on -- I left it working in the meantime with the forked version. So, feel free to close this one.

lbvo commented 6 years ago

Hi, First of all thanks a lot for this plugin, it was a perfect match for me! However I am trying to implement another strategy in to my api, where a certain route should be able to be configured with 2 strategies, where first would be allowed via query if fail fallback and verify authentication via other strategy in this occasion it would be a Bearer in the header. I am having trouble in doing this, that was when I found this PR, it seems highly related to my issue (yes?)

I would very much like to stay with this model for authentication, I have tried a few and this is the best of the bunch I have been working with.

What is the conclusion for this, it seems it was never merged to master ?

-- Have nice day, regards Lasse.

johnbrett commented 6 years ago

@lbvo this PR went stale unfortunately (likely my fault), I think a fresh PR will have to be made against master fixing this problem. I don't currently have time to create one myself, but would happily support you in making one to fix this problem if you're willing to?

nakardo commented 6 years ago

@lbvo @johnbrett if I have time I'll try to see if it's easy to port back the functionality from the old PR into the Hapi v17 code.

johnbrett commented 6 years ago

That would be awesome @nakardo!!