search

johnbrett / hapi-auth-bearer-token

Simple Bearer authentication scheme plugin for hapi, accepts token by Header, Cookie or Query parameter.
MIT License
218 stars 46 forks source link

Update all hapi libs to new module location #183

Closed cameronmoreau closed 5 years ago

cameronmoreau commented 5 years ago

All hapi modules were moved; non @hapi/* modules are no longer maintained

Looks like a previous commit or the lab upgrade dropped the coverage. This PR is a draft until CC is back at 100%

johnbrett commented 5 years ago

thanks for working on this @cameronmoreau - do you want me to review this or wait till you give the heads up?

cameronmoreau commented 5 years ago

@johnbrett np, back to 💯 so ready for review!

johnbrett commented 5 years ago

This is awesome work, no changes to tests 😍 always like to see that! Have left one question is all!

cameronmoreau commented 5 years ago

I'm probably just blind but I can't find the question you left. Do you mind linking to it @johnbrett ?

johnbrett commented 5 years ago

oh I think I had to hit "submit review" - does it show now ?

johnbrett commented 5 years ago

@cameronmoreau merged, and published as v6.2.0!

Thanks for this update, much appreciated 👍

taina0407 commented 5 years ago

@johnbrett could you please update "peerDependencies": { "hapi": ">=17.x.x" } to "peerDependencies": { "@hapi/hapi": ">=17.x.x" }

This will avoid warning " > hapi-auth-bearer-token@6.2.0" has unmet peer dependency "hapi@>=17.x.x"

cameronmoreau commented 5 years ago

Whoops @taina0407, fixed and pr'd #185

johnbrett commented 5 years ago

Nice catch @taina0407, thanks for fix @cameronmoreau. Merged and published as v6.2.1