search

johnbrett / hapi-auth-bearer-token

Simple Bearer authentication scheme plugin for hapi, accepts token by Header, Cookie or Query parameter.
MIT License
218 stars 46 forks source link

Resolve issue #209, doesn't work with new "joi" package. #210

Closed eric-swann-q2 closed 4 years ago

eric-swann-q2 commented 4 years ago

As described in issue #209 :

This lib has dependencies on @hapi/joi and @hapi/boom. The @hapi/joi dependency in particular causes a collision when using the new joi library as joi detects two versions and throws an exception.

Solution: Instead set both of the libraries as peer dependencies for maximum flexibility and reference "joi" as opposed to "@hapi/joi" for future versions.

taina0407 commented 4 years ago

@johnbrett any plan for this to merge and release ?

wy193777 commented 4 years ago

This one is the only dependency currently prevent me update to joi.

johnbrett commented 4 years ago

This merge was published as v8.0.0. I considered this a breaking change as it required a change in dependencies. Thanks again @eric-swann-q2.

@taina0407 @wy193777 please post here if any issues!

wy193777 commented 4 years ago

Thanks for your immediate response!

johnbrett commented 4 years ago

@wy193777 thank @eric-swann-q2, he did all the work here, I just dragged my heels, sorry all!