search

johncoleman83 / domain_scraper

Scrapes domains for broken links, emails & social media links (uses beautifulsoup)
MIT License
2 stars 3 forks source link

Modular-ize #5

Closed mrvnmchm closed 5 years ago

mrvnmchm commented 5 years ago

Created argument structure and modularized scripts to execute. Further work needed to clean up redundancies. Can start on that in next issue.

johncoleman83 commented 5 years ago

LGTM! Thanks sincerely. I found a bug in the way the input file is being created from the command arguments, and I would have preferred better user messages if the commands are not used properly. However, I'll just fix that in a few minutes, so good enough to merge. Thanks again!

johncoleman83 commented 5 years ago

Actually, I may have been mistaken and using the command incorrectly, because I think my update was only necessary if the input_file was provided like so input_file=foobar.txt. So, everything was working great, it was just hard for me to see how you had created that file because there was no custom error messages. Besides that one little nit, it is really nice work. Thanks again!