johndbritton / teleport

Virtual KVM for macOS
GNU General Public License v2.0
790 stars 132 forks source link

Can't transition back from client with full screen video #62

Open reaperhulk opened 3 years ago

reaperhulk commented 3 years ago

Bug report

When fullscreening a Safari video on a client machine and then trying to transition back to the host machine the mouse will not transition back. Using ctrl-opt-shift-esc allows it to transition back and then transitions work as expected until you exit fullscreen, at which point it gets stuck again and requires ctrl-opt-shift-esc to fix it.

Step-by-step reproduction instructions

Full screen a video in Safari on a client machine and attempt to transition back.

Environment information

Server (Mac with keyboard and pointing device)

(Machine has two monitors)

Client (Mac being remotely controlled)

johndbritton commented 3 years ago

@reaperhulk what does ctrl-opt-shift-esc do?

reaperhulk commented 3 years ago

@johndbritton it immediately pulls control back to the host. Then you can transition and it's fine. I believe this problem is because fullscreen video creates a new desktop, so teleport doesn't view that new virtual desktop as being the edge. If I transition back to the primary virtual desktop I can then transition back.

roderik commented 3 years ago

It is the same for full-screen apps btw

johndbritton commented 3 years ago

I did some digging on this and I believe it's related to how teleport detects edges for transition.

The way I understand it, when an edge is enabled for teleporting the app creates a transparent window with a specific width along that edge at the top of the views on screen. Then, when the mouse enters, it teleports.

I'd imagine that full screen apps / spaces do not display the transparent window on top because they are essentially a single app on screen.

reaperhulk commented 3 years ago

It does work for fullscreen video on the client though (e.g. if you fullscreen a video locally and then connect to a teleport server to control it then the transition edge works without problem), which is an odd inconsistency.

On Mon, Jan 11, 2021 at 1:09 PM John Britton notifications@github.com wrote:

I did some digging on this and I believe it's related to how teleport detects edges for transition.

The way I understand it, when an edge is enabled for teleporting the app creates a transparent window with a specific width along that edge at the top of the views on screen. Then, when the mouse enters, it teleports.

I'd imagine that full screen apps / spaces do not display the transparent window on top because they are essentially a single app on screen.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/johndbritton/teleport/issues/62#issuecomment-758161199, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABHNVZRFSUPACA7AH4G3NTSZNEGZANCNFSM4U75MO6A .

sugitach commented 3 years ago

I am encountering the same situation. In addition, when transitioning between a full-screen application and a non-full-screen application on the client side, the state of being able to return to the host side and not being able to return may be reversed. In my environment, it often happens when I open a full screen video from one window of chrome and transition between that screen and the other screens.

gastonmorixe commented 2 years ago

ctrl-opt-shift-esc works as a workaround, it happens for any fullscreen app

TheFou commented 1 year ago

In addition, when transitioning between a full-screen application and a non-full-screen application on the client side, the state of being able to return to the host side and not being able to return may be reversed

I encounter exactly the same behaviour. In my setup, I have about 8 spaces on the slave mac, some are standard desktops, some are fullscreen apps.

Master : Mac Studio / Ventura 13.2.1 Slave : Mac Pro 5,1 / Mojave 10.14.6 Teleport 1.3.5 on both

Hope it helps.