johndbritton / teleport

Virtual KVM for macOS
GNU General Public License v2.0
790 stars 132 forks source link

1.3.2 from home-brew is corrupted #87

Closed roderik closed 3 years ago

roderik commented 3 years ago

Bug report

What you were trying to do (and why)

Installed the update out of homebrew and both my intel and my arm mac mentioned it was corrupted and should be moved to bin. 1.3.1 works perfectly.

roderik commented 3 years ago

oh and reinstalling it several times did not help :)

johndbritton commented 3 years ago

@roderik Can you be more specific? Can you paste the exact error messages you got?

johndbritton commented 3 years ago

I reproduced this as follows:

john@jdb-pro|~
) brew uninstall --cask abyssoft-teleport
==> Uninstalling Cask abyssoft-teleport
==> Backing App 'teleport.app' up to '/usr/local/Caskro
==> Removing App '/Applications/teleport.app'.
==> Purging files for version 1.2.2 of Cask abyssoft-te
john@jdb-pro|~
) brew install --cask abyssoft-teleport
######################################################################## 100.0%
==> Installing Cask abyssoft-teleport
==> Moving App 'teleport.app' to '/Applications/telepor
🍺  abyssoft-teleport was successfully installed!
Screen Shot 2021-01-05 at 1 09 18 PM
johndbritton commented 3 years ago

Looks like the cask was updated in https://github.com/Homebrew/homebrew-cask/pull/97198.

It seems that the auto-updater can install v1.3.2 fine, but it can't be installed directly.

johndbritton commented 3 years ago

This isn't a solution, but running xattr -cr /Applications/teleport.app will allow v1.3.2 to run. Not sure what exactly is causing the damaged warning.

johndbritton commented 3 years ago
spctl -a -vvv ~/Downloads/teleport.app
/Users/john/Downloads/teleport.app: a sealed resource is missing or invalid

This is an issue with notarization of the application. Looks like the notarization ticket was not correctly stapled during the automated build.

johndbritton commented 3 years ago

@roderik I released v1.3.3 which should fix this issue.

For Homebrew to work, the cask will need to be updated.

I verified the notarization and code signature generated with the automated build process:

On v1.3.2:

john@jdb-pro|~/src/johndbritton
) spctl -a -vvv ~/Desktop/teleport.app
/Users/john/Desktop/teleport.app: a sealed resource is missing or invalid
-> [1]
john@jdb-pro|~/src/johndbritton
) codesign --verify --verbose ~/Desktop/teleport.app
/Users/john/Desktop/teleport.app: bundle format is ambiguous (could be app or framework)
In subcomponent: /Users/john/Desktop/teleport.app/Contents/Frameworks/Sparkle.framework

On v1.3.3:

john@jdb-pro|~/src/johndbritton
) spctl -a -vvv ~/Desktop/teleport.app
/Users/john/Desktop/teleport.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: John Britton (57XRX9DK57)
john@jdb-pro|~/src/johndbritton
) codesign --verify --verbose ~/Desktop/teleport.app
/Users/john/Desktop/teleport.app: valid on disk
/Users/john/Desktop/teleport.app: satisfies its Designated Requirement
johndbritton commented 3 years ago

This will be fixed in Homebrew once https://github.com/Homebrew/homebrew-cask/pull/97308 is merged.

roderik commented 3 years ago

Awesome, thanks!