johnding1996 / HKUST-COMP3111H-Group

Group Project of COMP 3111H in Fall 2017 at HKUST
Apache License 2.0
0 stars 0 forks source link

Design the Project's Package Hierarchy #22

Closed johnding1996 closed 7 years ago

johnding1996 commented 7 years ago
johnding1996 commented 7 years ago

@thomaszhouan What's the controller team's idea on the package names for all parts of the project?

thomaszhouan commented 7 years ago

The proposed hierarchy is as follows:

thomaszhouan commented 7 years ago

The commit 369f1e2f060e6b5aaf5ab68f810f671da4c3fabd still contains legacy code from the kitchensink sample. It will be integrated into the new controller.

johnding1996 commented 7 years ago

@thomaszhouan Thanks for the great work. I completely agree with the proposal.

thomaszhouan commented 7 years ago

The hierarchy proposed has been included in the wiki.

It seems that the GitHub integration of Slack cannot show wiki update events. Any suggestions?

thomaszhouan commented 7 years ago

A proposal on the project hierarchy: add a new package named utility for the reuse of some common functions needed by multiple modules, such as checking whether input string is int, split a sentence into words. @johnding1996

johnding1996 commented 7 years ago

@thomaszhouan but could this be inside the agent package?

thomaszhouan commented 7 years ago

The following package may need these utilities: controller, agent, misc. The reason why controller also needs such functions is it has to process user input directly sometimes (say Idle state), in order to decide which task user wants to perform (recommendation/feedback/initial input).

johnding1996 commented 7 years ago

@thomaszhouan ok, then do so, we can do refactoring after m2 anyway. But, I suggest you close the current controller branch and do this change to develop by opening another feature branch.