search

johnding1996 / HKUST-COMP3111H-Group

Group Project of COMP 3111H in Fall 2017 at HKUST
Apache License 2.0
0 stars 0 forks source link

Feature/state machine #25

Closed thomaszhouan closed 7 years ago

thomaszhouan commented 7 years ago
codecov[bot] commented 7 years ago

Codecov Report

Merging #25 into develop will increase coverage by 17.8%. The diff coverage is 74.7%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #25      +/-   ##
============================================
+ Coverage         16%   33.8%   +17.8%     
- Complexity         9      22      +13     
============================================
  Files              5       6       +1     
  Lines            218     313      +95     
  Branches          15      30      +15     
============================================
+ Hits              35     106      +71     
- Misses           183     197      +14     
- Partials           0      10      +10
Impacted Files Coverage Δ Complexity Δ
...atbot/src/main/java/controller/DatabaseEngine.java 10.3% <ø> (ø) 2 <0> (?)
...ot/src/main/java/controller/SQLDatabaseEngine.java 94.1% <ø> (ø) 7 <0> (?)
...c/main/java/controller/KitchenSinkApplication.java 0% <ø> (ø) 0 <0> (?)
...rc/main/java/controller/KitchenSinkController.java 0% <ø> (ø) 0 <0> (?)
...n/java/controller/KitchenSinkWebMvcConfigurer.java 0% <ø> (ø) 0 <0> (?)
...chatbot/src/main/java/controller/StateMachine.java 74.7% <74.7%> (ø) 13 <13> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 701deb0...190380b. Read the comment docs.

johnding1996 commented 7 years ago

Passed, do you have privilege to merge? @thomaszhouan I protected the develop and master branch, the criteria to pass a pull request is Travis.

thomaszhouan commented 7 years ago

I can merge myself, after fixing the CodeFactor issue first.