Feature/controller refactor

[thomaszhouan]

Controller v2.0 is ready.

New features

• State changes freely as required, no need the concept of StateTransition
• More robust communication schemes for agent and controller
• Using Redis cache layer for state tracking

[codecov[bot]]

Codecov Report

Merging #87 into develop will decrease coverage by 41%. The diff coverage is 10.5%.

@@             Coverage Diff              @@
##             develop     #87      +/-   ##
============================================
- Coverage       66.7%   25.6%   -41.1%     
+ Complexity       328     142     -186     
============================================
  Files             36      35       -1     
  Lines           1589    1304     -285     
  Branches         176     173       -3     
============================================
- Hits            1060     334     -726     
- Misses           453     942     +489     
+ Partials          76      28      -48

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/controller/DietingChatbotApplication.java	0% <ø> (ø)	0 <0> (ø)	:arrow_down:
...g-chatbot/src/main/java/utility/TextProcessor.java	80% <ø> (ø)	2 <0> (ø)	:arrow_down:
...n/java/controller/KitchenSinkWebMvcConfigurer.java	0% <ø> (ø)	0 <0> (ø)	:arrow_down:
...ng-chatbot/src/main/java/controller/Publisher.java	0% <ø> (ø)	0 <0> (ø)	:arrow_down:
...g-chatbot/src/main/java/agent/FoodRecommender.java	0% <0%> (-88.2%)	0 <0> (-19)
...ing-chatbot/src/main/java/utility/JsonUtility.java	0% <0%> (ø)	0 <0> (?)
...ot/src/main/java/utility/FormatterMessageJSON.java	0% <0%> (ø)	0 <0> (?)
...hatbot/src/main/java/controller/DebugReceiver.java	0% <0%> (ø)	0 <0> (ø)	:arrow_down:
...ting-chatbot/src/main/java/agent/MealRecorder.java	0% <0%> (ø)	0 <0> (?)
...atbot/src/main/java/agent/IntentionClassifier.java	0% <0%> (ø)	0 <0> (?)
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4036be...c42671e. Read the comment docs.

[johnding1996]

@thomaszhouan About the inappropriate unittests, I think you should kept them with sth like @Ignore("wait for controller v2.0 updates"). Currently you simply delete them?

[johnding1996]

@thomaszhouan Is it possible to write a unittests for only one agent as demonstration in this PR. This could be very helpful for other developers in the group. Other unittests could be finished gradually and with the help of others. If you felt lacking of time, I can ask some others to help.

[johnding1996]

@thomaszhouan Two issues found by black box testing so far.

1. Can input dates like 2017-623-23 or 2017-10-63
2. When run recommend after correct initial input, it prompts I don't have your info yet ... session canceled no way to continue now.

[thomaszhouan]

@johnding1996 The first issue will be fixed in the next commit. For the second issue, I could not reproduce such error. Could you provide more details?

A possible cause is that the incorrect date format causes error when adding user info to database, and subsequent test will fail.

[johnding1996]

@thomaszhouan Yes, it is due to no validation when input dates. Now black box testing passed.