johndoh / roundcube-contextmenu

Adds context menus to various parts of Roundcube
https://plugins.roundcube.net/#/packages/johndoh/contextmenu
94 stars 30 forks source link

First have to left click #135

Closed remkohat closed 1 year ago

remkohat commented 1 year ago

Installed roundcube 1.4.3 (elastic skin) and plugins from Ubuntu 20's repo. Manually upgraded contextmenu to 3.3.1 because repo contains 2.3 which has no elastic skin.

When right clicking on a folder that wasn't first left clicked makes a servererror appear at the bottom right of the window. The contextmenu appears but whatever you click doesn't do a thing. Same for emails that weren't first left clicked but without the error.

Only if you first left click a folder or email before you right click it than the contextmenu works fine.

ichiru5555 commented 1 year ago

Is it an error if I download roundcube from https://roundcube.net/download/ instead of the repository?

remkohat commented 1 year ago

Manual upgrade to the latest 1.4.13 seems to give a little improvement.

I can now right click emails and do things from within the contextmenu to it without first having to left click the email. Right clicked folders that weren't first left clicked still give a servererror at the bottom right but things clicked on in the contextmenu do get done.

Using the original elastic skin or my own elastic hooked skin doesn't make a difference.

ichiru5555 commented 1 year ago

Are there any errors in the roundcube logs or server logs?

remkohat commented 1 year ago

Yesterday I didn't have relevant errors in the logs, but since RC's upgrade this morning I get this:

2022/11/16 11:24:10 [error] 2089995#2089995: *329 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught Error: Call to undefined method rcube_utils::get_input_string() in /usr/share/roundcube/plugins/contextmenu/contextmenu.php:71
Stack trace:
#0 /usr/share/roundcube/program/lib/Roundcube/rcube_plugin_api.php(522): contextmenu->messagecount()
#1 /usr/share/roundcube/index.php(292): rcube_plugin_api->exec_action()
#2 {main}
  thrown in /usr/share/roundcube/plugins/contextmenu/contextmenu.php on line 71" while reading response header from upstream, client: _ClientIP_, server: _, request: "POST /roundcube/?_task=mail&_action=plugin.contextmenu.messagecount HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm.sock:", host: "_ServerName_", referrer: "https://_ServerName_/roundcube/?_task=mail&_mbox=Trash"
ichiru5555 commented 1 year ago

It looks like you are calling an undefined method. Please check the file that is giving the error once.

johndoh commented 1 year ago

This sounds like a version compatibility issue. You said you were running Roundcube 1.4.3 and Contextmenu 3.3.1 but v3.3.1 is for Roundcube 1.5 and above.

Now you have Roundcube 1.4.13 you could use v3.2.1 of Contextmenu . See the releases page for all versions.