search

johndoh / roundcube-swipe

Adds swipe actions to the message list of Roundcube
https://plugins.roundcube.net/#/packages/johndoh/swipe
11 stars 5 forks source link

contradictory expression #6

Closed michaelchong2005 closed 5 years ago

michaelchong2005 commented 5 years ago

Is this expression contradictory? and line 227 is the same. changeX < 5 && changeX > -5

https://github.com/johndoh/roundcube-swipe/blob/0b2eecc39733a09b836d944142ec20529732a7c4/swipe.js#L224

johndoh commented 5 years ago

Inelegant perhaps but I don't think contradictory. I could use something like Math.abs() do make sure the val is always positive and simplify the checks.

michaelchong2005 commented 5 years ago

I mean this paragraph 'changeX < 5 && changeX > -5', do you think so?

johndoh commented 5 years ago

that simply means that changeX has to be between -4 and 4

johndoh commented 5 years ago

done in git master