search

johndwells / Minimee

Minimize & combine your CSS and JS files. Minify your HTML. Because size (still) DOES matter.
http://johndwells.github.com/Minimee
56 stars 16 forks source link

Minify html breaks large files #5

Closed willmcclellan closed 10 years ago

willmcclellan commented 12 years ago

Great work on V2 of Minimee John. One thing I've noticed is that when minify html is on, some big files (e.g. json data files) break and output nothing.

I'm guessing this has something to do with the size of the file after a certain point. Not a major problem, but thought I'd let you know.

johndwells commented 12 years ago

Hi Will,

Thanks for the praise, though I'm struggling to finish it! Just hard to find the time outside of work.

Would you mind sending me an example of a file which causes the html minification to choke? It'd be helpful to have something to test. john at johndwells dot com.

Cheers! John

willmcclellan commented 12 years ago

Hi John,

It's well deserved, I don't know how you find time/energy to get anything like this done outside of work! I struggle with just the work.

I've attached an example of the file. It's quite a hefty json format which I'm guessing is the problem as it runs over a lot of lines.

Hope that helps.

Thanks,

Will

On 18 July 2012 10:23, John D Wells < reply@reply.github.com

wrote:

Hi Will,

Thanks for the praise, though I'm struggling to finish it! Just hard to find the time outside of work.

Would you mind sending me an example of a file which causes the html minification to choke? It'd be helpful to have something to test. john at johndwells dot com.

Cheers! John

Reply to this email directly or view it on GitHub: https://github.com/johndwells/Minimee/issues/5#issuecomment-7061041

Will McClellan Happycry, Director & Web Designer

www.happycry.co.uk will@happycry.co.uk 0151 909 4007

johndwells commented 12 years ago

Hi Will,

Sorry to ask you about this again, but could you possibly re-send the example of json file that was causing Minimee grief? I can't seem to find it.

Cheers, John

johndwells commented 10 years ago

Hi Will,

I'm closing out this old issue. HTML minification is in and of itself a taxing process, so it should be used with caution. Note also that an upcoming release (2.2) will integrate with CE Cache to defer the HTML minification to CE Cache's hooks so that HTML minification is done prior to being saved as a cache fragment. When this is released, it will be what I recommend as the preferred way to HTML minify content.

Cheers, John