Missing start comma in OSC Type Tag String

johnelse / ocaml-osc

Pure OCaml implementation of the Open Sound Control protocol

MIT License

25 stars 8 forks source link

Missing start comma in OSC Type Tag String #2

Closed darioteixeira closed 10 years ago

darioteixeira commented 10 years ago

According to the spec [1], the OSC Type Tag String should begin with the character ',' (comma). OCaml-OSC is not doing this, which causes interoperability failures.

[1] http://opensoundcontrol.org/spec-1_0

johnelse commented 10 years ago

Whoops, good catch - thanks! That's actually the spec I've been working from, so I don't know how I managed to miss that...

Just FYI, this library is very much a work in progress at the moment - expect rewrites and general hackery while I try and get the API into a nice shape. You are of course welcome to play with it in the mean time :)

darioteixeira commented 10 years ago

You're welcome! And yes, I did hesitate to submit this bug report because I realise the project is still in a state of flux, and this is the sort of problem you would've caught right away when you tried communicating with peers not based on your library... Anyway, hopefully this report spared you an often frustrating session of wire-sniffing!

johnelse commented 10 years ago

Fixed in c3cdb668898e065556e8b2539abb677f20edfd5b, thanks again!