search

johnewart / gearman-ruby

Official! Ruby library for the Gearman distributed job system
http://gearman.org/
MIT License
97 stars 32 forks source link

undefined method `hostport' for <ip:port> (connected: false):Gearman::Connection #26

Open tamoyal opened 9 years ago

tamoyal commented 9 years ago

I think

message = "Network error on read from #{connection.hostport} while adding job, marking server bad"

should be

message = "Network error on read from #{connection.to_host_port} while adding job, marking server bad"

I don't see hostport defined in the Connection class

lucaslain commented 9 years ago

Was this fixed?

tamoyal commented 9 years ago

Hmmm not sure I ever got the pull request completed for this but here's the fix: https://github.com/tamoyal/gearman-ruby/commit/4d03d23f2e7aec03fe9d359ffc23dce04ef7439a ...quite simple

And here is the PR: https://github.com/johnewart/gearman-ruby/pull/27

tamoyal commented 6 years ago

@johnewart any chance we can get this pulled in?