johnf / storybook-addon-jotai

MIT License
6 stars 10 forks source link

Support Jotai v2 #17

Open haydnhkim opened 1 year ago

haydnhkim commented 1 year ago

I wanted to reach out and let you know that I have completed the update to the Storybook plugin for storybook-addon-jotai to support Jotai v2. Previously, the plugin only supported Jotai v1, but with this update, it will now be compatible with the latest version of Jotai.

I would like to submit a Pull Request for your review, as I believe this update will greatly benefit users of the storybook-addon-jotai by providing them with an improved and up-to-date plugin.

Please let me know if there is anything else you need from me or if you have any questions about the changes I have made. I look forward to hearing back from you and appreciate your time in reviewing the code.

Thank you for your consideration.

Changes:

closes #16

johnf commented 1 year ago

@haydnhkim This looks great! I was planning on upgrading my own version some time this week. I'll use that as an opportunity to test and then aim to merge.

johnf commented 1 year ago

@haydnhkim I'm using jotai a lot less in the app I originally created this for and keeping storybook up to date hasn't been a priority. Would you be interested in taking on maintainership of this package?

haydnhkim commented 1 year ago

@johnf Yes, I am interested. With the recent update to Storybook v7, there are a lot of changes that need to be made. I've been working on this and would be able to do a large update if I had permissions.

johnf commented 1 year ago

I've added you as a collaborator. Let me know once you want to publish something and we'll work out best way to deal with NPM.

haydnhkim commented 1 year ago

Thank you. I'll comment when I need to publish to NPM.