search

johnfactotum / foliate-js

Render e-books in the browser
https://johnfactotum.github.io/foliate-js/reader.html
MIT License
318 stars 43 forks source link

[Question] NPM package #13

Closed ewilan-riviere closed 10 months ago

ewilan-riviere commented 10 months ago

I really like what you're doing on foliate, I just need to know if you plan to export your library to NPM. If not, would you be interested in a Pull Request? Or is that really not your goal here?

And if you don't want to do it, would you mind if I made an NPM library based on your work on another repo (referencing you as the original author, of course)?

johnfactotum commented 10 months ago

Thanks! I wouldn't mind a PR to add a package.json or if you publish your own package. I do plan on publishing it on NPM at some point, perhaps after the GTK 4 version of Foliate is released, as the library is still too unstable.

ewilan-riviere commented 10 months ago

Thank you for your reply! I'm going to work on an adaptation to make an NPM export on a PR. But I still have a quick question first: if I do this in Typescript (with some tools like eslint), will it cause any problems? I can keep the Javascript, if you prefer!

The library may be ready for a more stable version, or even be available as an alpha or beta version. I'll leave it to you to decide what you'd prefer to do once I've published the PR.

johnfactotum commented 10 months ago

Not entirely sure, but I think you can directly export the native ESM modules in package.json (with multiple entry points). I would much prefer that if possible.

ewilan-riviere commented 10 months ago

Yes, it is totally possible, no problem. I will keep Javascript!