LostQuasar
commented
3 weeks ago That's fair perhaps my use case for this software is bike shed.
On Sun, Nov 3, 2024, 8:34 PM John Factotum @.***> wrote:
- I don't think there's really a strong need to remove the file extension. Evince, for example, shows the whole file name in the title bar.
- Not all files have extensions, and the part after . might be part of the title, though this is admittedly an edge case.
- It's possible for files of other types to lack titles. So it might be better to handle this in the application code, or in
. The reason for dealing this in the application code is that in some cases one might need to know whether the book has a real title or not. In sum, in my opinion it would be better to
- Try to get real metadata from comic book files (e.g. ComicInfo.xml), and if not available, leave metadata empty.
- In view.js, either always set missing title to filename, or expose the filename to the application.
— Reply to this email directly, view it on GitHub https://github.com/johnfactotum/foliate-js/pull/41#issuecomment-2453685235, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZ3QPCH4C272QZSNKJRVWDZ63FKDAVCNFSM6AAAAABRDIR2V2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGY4DKMRTGU . You are receiving this because you authored the thread.Message ID: @.***>
.might be part of the title, though this is admittedly an edge case.<foliate-view>. The reason for dealing this in the application code is that in some cases one might need to know whether the book has a real title or not.In sum, in my opinion it would be better to
view.js, either always set missing title to filename, or expose the filename to the application.