search

johnfactotum / foliate

Read e-books in style
https://johnfactotum.github.io/foliate/
GNU General Public License v3.0
5.26k stars 256 forks source link

Consider bumping version number #1238

Open jbicha opened 5 months ago

jbicha commented 5 months ago

Debian had a bug in their packaging scripts and accidentally updated their version number for Foliate to 4

Would you consider bumping your version number to something larger like 4.0 ?

johnfactotum commented 5 months ago

Would it be possible to bump the package's epoch, which according to man deb-version, is "provided to allow mistakes in the version numbers of older versions of a package"?

jbicha commented 5 months ago

Debian discourages the use of epochs since it is a permanent and heavy solution to what could be a temporary problem.

For instance, if gtk4 bumps the epoch to 1 then everybody that wants to set the minimum dependency on gtk4 4.12 would need to remember to use libgtk-4-dev (>= 1:4.12) instead of the simpler, more common libgtk-4-dev (>= 4.12). And if the epoch is bumped again, then everything needs to be updated for that. Obviously, Foliate does not have as many things depending on it as GTK does, but it's the general idea.

So now, Foliate in Debian has the version number 4.~really3.1.0-0.1 instead of a prettier 4.0-0.1.

johnfactotum commented 5 months ago

Well, I have no strong opinion on this. Still it might seem odd to make what would look like a major release when there are no major or even minor changes.

Don't know if it would work, but IMO it would be better if the version could be simply corrected, which probably means that people need to downgrade, but it's a one time action.

jbicha commented 5 months ago

Debian does not allow downgrading. The ugly version number is the best I was able to do on the Debian side. It's a small detail. Except for that, it works fine.

johnfactotum commented 5 months ago

OK. I guess here are the options:

  1. Do nothing. Bump epoch in Debian.
  2. Do nothing. Debian stuck with incorrect version number until the presumed eventual release of 4.0.0.
  3. Do nothing for now, but in the future make what would have been 3.2.0 or 3.1.1 4.0.0 instead.
  4. Bump the version to 4.0.0 now, and release it immediately.

Another idea is that one could bump it to something like 45, which would be in line with GNOME's version number and slightly less confusing than 4.0 without any major changes.

Yet another idea is that, instead of 4.~really3.1.0, just call it 4.3.1.0 in Debian. Less ugly and the 4 can be taken to mean "GTK 4". Then on Foliate's side, it would skip 4.x and jump to 5.0 if there's a new major release.

jbicha commented 5 months ago

I'm not going to do # 1, but you're welcome to do any of the other options.

I chose the ~really to allow catching up with the actual version numbers at the earliest possible time. It doesn't matter to me at all if you choose to use 4.3.1 instead of 4.0, etc.