search

johnfactotum / foliate

Read e-books in style
https://johnfactotum.github.io/foliate/
GNU General Public License v3.0
5.25k stars 254 forks source link

Inside a book, `Ctrl+F` search keyboard shortcut does not work if the book pages are focused instead of the sidebar #1299

Closed nekohayo closed 2 months ago

nekohayo commented 2 months ago

To Reproduce Steps to reproduce the behavior:

  1. Enter a book
  2. Click on the Search button
  3. Press Esc to toggle off the search
  4. Press Ctrl+F, notice the searchbar reappears
  5. Press Esc to toggle off the search
  6. Click the book's page contents on the right, so that the focus is no longer on the sidebar (even if the sidebar is pinned)
  7. Press Ctrl+F to try to activate and focus (and select-all) the searchentry's contents

Expected behavior Search entry gets reactivated, and existing query text (if any) should be all preselected (so that the user can replace/overwrite it, or choose to extend it instead)

Version:

Additional context Running in Wayland.

johnfactotum commented 2 months ago

See https://github.com/johnfactotum/foliate/issues/1279#issuecomment-2017195341

  • OS/Distribution and version: Fedora 39

  • Desktop environment: GNOME 45

Guess that means it was caused by a change in how WebKitGTK handles shortcuts.

At any rate, this should be fixed in v3.1.1.